search

CodeWithDennis / filament-select-tree

The multi-level select field lets you pick one or multiple options from a list that is neatly organized into different levels.
MIT License
225 stars 33 forks source link

add rtl support #45

Closed ariaieboy closed 11 months ago

ariaieboy commented 11 months ago

image

with selected property image

ariaieboy commented 11 months ago

@CodeWithDennis it's ready to merge

CodeWithDennis commented 11 months ago

@ariaieboy If you can take a look at my latest comments and fix them we can merge it =)

ariaieboy commented 11 months ago

@CodeWithDennis I can't find your comments.

CodeWithDennis commented 11 months ago

@CodeWithDennis I can't find your comments.

https://github.com/CodeWithDennis/filament-select-tree/pull/45/files

ariaieboy commented 11 months ago

@CodeWithDennis I can't find your comments.

https://github.com/CodeWithDennis/filament-select-tree/pull/45/files

I can't see any comments on the codes I created a test comment.

CodeWithDennis commented 11 months ago

@CodeWithDennis I can't find your comments.

https://github.com/CodeWithDennis/filament-select-tree/pull/45/files

I can't see any comments on the codes I created a test comment.

TLDR:

Can we make this prettier:

  1. rtl: '{{ ((__('filament-panels::layout.direction')??'ltr')=='rtl'?true:false) }}'

  2. src/SelectTree.php line 337 you removed a space

ariaieboy commented 11 months ago

@CodeWithDennis Is it good now?