search

CodeWithEmad / apyrat

An Aparat video and playlist downloader. simple, but elegant.
MIT License
20 stars 1 forks source link

prompt when confirm flag is and quality is not provided #2

Closed Amir-m-a closed 7 months ago

Amir-m-a commented 1 year ago

if quality is not provided prompt is always used, which is not desirable when batch downloading and only best quality is desired: https://github.com/CodeWithEmad/apyrat/blob/50409df64ee87706832adbe459f283a60d7b6638/apyrat/cli.py#L82-L89

something like this would be better imo:

if not quality:
    if confirm:
        return downloader.default_quality()
    else:
        ...
CodeWithEmad commented 1 year ago

Nice catch! Would you like to open a PR?