CodeWithPraveen / labs-docker-privateregistry

Repo for the "Build and Manage a Private Docker Registry" lab
1 stars 1 forks source link

[Feature Request] Your CICD should go until the deployment to App Service #4

Closed benoitLebreton-perso closed 1 year ago

benoitLebreton-perso commented 1 year ago

Your github actions CICD stop at the push to the container registry.

It would be so better if you add a step "Deployment to the App Service" at the end.

You could have two steps with :

and the tag would be the same as the github tag (instead of just hard coding the 1.0.0)

CodeWithPraveen commented 1 year ago

Hi there,

Thanks for sharing your comments. The steps were kept simple as it was targeting beginners. It is possible to use Azure CLI to manage it better with more controls. However, it will then be outside the scope of this lab.

I have taken note of your feedback. I will review it when I do a related lab on this topic.

Thank you, Praveen