CodeWringer / strive-foundryVTT

STRIVE system for FoundryVTT
GNU General Public License v3.0
1 stars 0 forks source link

Extract explicit document type statements to constants #161

Closed CodeWringer closed 6 months ago

CodeWringer commented 1 year ago

For example, any reference to "fate-card" should instead refer to a global constant that holds this string.

CodeWringer commented 1 year ago

The use of this refactoring is questionable. Introducing constants would imply the need for imports in many places. The name of document types isn't expected to change often, either, as changing a document's type name already implies several breaking changes.