CodeWritingCow / NYC-restaurant-inspection-records

Web application for searching New York City restaurant inspection records
http://www.nycfoodsafety.org
1 stars 3 forks source link

Add React base 404 page #58

Closed CodeWritingCow closed 5 years ago

CodeWritingCow commented 5 years ago

Converted 404 page from Handlebars to React component,<NotFound/>

Modified dist/index.html to load bundle.js and style.css from absolute path rather than relative path. This prevents the client from looking for those files in the wrong directory if users visit a nested route. Previously, if a user visited localhost:8080/pagenotfound/pagenotfound, React tried to load localhost:8080/pagenotfound/bundle.js instead of the correct path, localhost:8080/bundle.js.

badwolfbit commented 5 years ago

@CodeWritingCow there is only a stylistic issue that needs to be addressed before merging

Original:

Screenshot 2019-07-16 14 30 53

PR #58:

Screenshot 2019-07-16 14 30 47
CodeWritingCow commented 5 years ago

@omenwolf I addressed the styling issue by increasing the margin top of Parallax's content. The React 404 page looks identical to the original Handlebars page.

badwolfbit commented 5 years ago

@CodeWritingCow Looks great, will merge