Closed CodeWritingCow closed 5 years ago
@CodeWritingCow there is only a stylistic issue that needs to be addressed before merging
@omenwolf I addressed the styling issue by increasing the margin top of Parallax's content. The React 404 page looks identical to the original Handlebars page.
@CodeWritingCow Looks great, will merge
Converted 404 page from Handlebars to React component,
<NotFound/>
Modified
dist/index.html
to load bundle.js and style.css from absolute path rather than relative path. This prevents the client from looking for those files in the wrong directory if users visit a nested route. Previously, if a user visitedlocalhost:8080/pagenotfound/pagenotfound
, React tried to loadlocalhost:8080/pagenotfound/bundle.js
instead of the correct path,localhost:8080/bundle.js
.