search

CodeYellowBV / chartist-plugin-legend

Legend plugin for Chartist.js.
https://codeyellowbv.github.io/chartist-plugin-legend/
Other
116 stars 62 forks source link

Using signals and classes #40

Closed doctormo closed 7 years ago

doctormo commented 7 years ago

I've made a new fork of chartist-plugin-legend, you can see it in the forks list. It probably shouldn't be merged in as it's a) guts the project code like a fish and b) has a new license.

But I bring it up because the idea of using chartist signals to add and keep legends up to date is worth considering. It's much cleaner to have chartist tell me when a series is being drawn than try and tie lots of indexes together from copied arrays.

SpaceK33z commented 7 years ago

Hey, this is an interesting idea. It would also fix #5, which is a nice bonus. Would you mind preparing a PR? Perhaps with an added test that checks if legends are not duplicated (not sure if this is necessary)?

doctormo commented 7 years ago

Not sure if I can make a merge request, it's such a large change. I'll post it, but feel free to shoot it down.

amichair commented 7 years ago

+1

aendu commented 7 years ago

so what is the status here? As far as i see it, update does still not work. But i might have done something wrong? Thx for an update.

doctormo commented 7 years ago

@aendu - Forked with regret: https://github.com/doctormo/chartist-plugin-legendary