CodeYellowBV / mobx-spine

MobX with support for models, relations and an external API.
31 stars 14 forks source link

Add different way to define relations on models #143

Closed stefanmajoor closed 11 months ago

codecov-commenter commented 11 months ago

Codecov Report

Merging #143 (5237677) into master (f1462a1) will increase coverage by 0.07%. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CodeYellowBV/mobx-spine/pull/143/graphs/tree.svg?width=650&height=150&src=pr&token=Fnb8AhOVNz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CodeYellowBV)](https://app.codecov.io/gh/CodeYellowBV/mobx-spine/pull/143?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CodeYellowBV) ```diff @@ Coverage Diff @@ ## master #143 +/- ## ========================================== + Coverage 93.69% 93.77% +0.07% ========================================== Files 5 6 +1 Lines 857 868 +11 Branches 203 204 +1 ========================================== + Hits 803 814 +11 Misses 44 44 Partials 10 10 ``` | [Files](https://app.codecov.io/gh/CodeYellowBV/mobx-spine/pull/143?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CodeYellowBV) | Coverage Δ | | |---|---|---| | [src/Model.js](https://app.codecov.io/gh/CodeYellowBV/mobx-spine/pull/143?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CodeYellowBV#diff-c3JjL01vZGVsLmpz) | `91.30% <100.00%> (+0.14%)` | :arrow_up: | | [src/Relations.js](https://app.codecov.io/gh/CodeYellowBV/mobx-spine/pull/143?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CodeYellowBV#diff-c3JjL1JlbGF0aW9ucy5qcw==) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/CodeYellowBV/mobx-spine/pull/143?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CodeYellowBV). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CodeYellowBV) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/CodeYellowBV/mobx-spine/pull/143?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CodeYellowBV). Last update [f1462a1...5237677](https://app.codecov.io/gh/CodeYellowBV/mobx-spine/pull/143?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CodeYellowBV). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CodeYellowBV).
stefanmajoor commented 11 months ago

Please add a test for nested relations defined in the new way.

It is there