CodeYellowBV / re-cy-cle

React component library for Code Yellow
https://codeyellowbv.github.io/re-cy-cle/
6 stars 6 forks source link

Add "secondary" / "danger"-style buttons #21

Closed SpaceK33z closed 7 years ago

SpaceK33z commented 7 years ago

For TMS we need buttons that have a "danger" look (for actions deleting stuff), and a "secondary" look, for actions like "Close".

I think <Button tone="secondary" /> might make sense.

SpaceK33z commented 7 years ago

Tip: when in doubt about the prop name, I always check out some other style guides: https://github.com/CodeYellowBV/re-cy-cle/#inspiration

Rutger commented 7 years ago

@RogerKemp How do button colors behave in our design language? We usually use the primary branding color for normal buttons. That means we have red normal buttons in HN. We should vary the colors by the app theme. Probably use black buttons for a tone="danger"-style in HN, and use red in TMS?

SpaceK33z commented 7 years ago

Not Roger, but I think we should make these tones configurable in the theme settings.