search

CodeYellowBV / tarantino

a tiny and isomorphic URL router for JavaScript.
MIT License
11 stars 3 forks source link

PRs from Director #3

Closed mhulse closed 7 years ago

mhulse commented 7 years ago

I was looking through the PRs for Director.

I would not mind bringing those over to your fork.

Some are kinda old (but they may still be valid).

Wondering if I should work my way down from top (most recent first) and start doing copies of (valid) PRs here?

Really, this should not take long. A lot of these things are simple changes.

What kind of tests do we have setup for Tarantino? Is this documented?

SpaceK33z commented 7 years ago

The contributing.md file documents how to run the tests. I have also setup Travis CI.

I've taken a quick look through the existing PR's, but many are not in good state.

https://github.com/flatiron/director/pull/300 - IE polyfills should not be added in libraries https://github.com/flatiron/director/pull/330 - bower is deprecated, just use npm https://github.com/flatiron/director/pull/267 - I've implemented Rollup instead of Gulp+Browserify

Good PR's: https://github.com/flatiron/director/pull/334 https://github.com/flatiron/director/pull/331 https://github.com/flatiron/director/pull/307

Thanks for helping btw!

mhulse commented 7 years ago

Awesome, thanks for eyeballing! I'll do those 3 good ones you mentioned. I can do this tonight or over this week/weekend. :octocat:

mhulse commented 7 years ago

Others?

SpaceK33z commented 7 years ago

Nice work :). I think that is it for now.

I'll look into moving this to a separate organisation soon (need to go back to work now). I'll add you as an admin then too. By making it an org we can assure that even if I would move on, it can live and florish 🌷 . We could consult with Flatiron afterwards to see if they are interested in linking to our repo in the README.

mhulse commented 7 years ago

Nice work :). I think that is it for now.

Perfect! Thanks!

I'll look into moving this to a separate organisation soon (need to go back to work now). I'll add you as an admin then too. By making it an org we can assure that even if I would move on, it can live and florish 🌷 . We could consult with Flatiron afterwards to see if they are interested in linking to our repo in the README.

No pressure from me. Though, I do think if this did happen, it would help to get people interested. I've done a bit of looking lately, and the state of JS routers is pretty poor. Director/Tarantino is definitely on the top of the heap IMO.

I'm totally down to help out though, so let me know if I can help with anything to get the ball rolling. :)

Thanks again dude!