Grammarly to be supported by PD CMS

CodeYourFuture / CYF-PD

Development Platform for PD team

https://cyf-pd.netlify.app/

Creative Commons Attribution 4.0 International

1 stars 5 forks source link

Grammarly to be supported by PD CMS #36

Closed kfklein15 closed 7 months ago

kfklein15 commented 10 months ago

AS A PD Volunteer I WANT to be able to review my text a final time on the CMS using Grammarly SO THAT I can ensure we reduce English errors

Acceptance criteria

Grammarly should run on any of the fields of the CMS

Tech Notes I ran the test Grammarly suggests, in order to identify that is wasn't supported

SallyMcGrath commented 10 months ago

Hi @kfklein15

It looks to me that this only happens when you choose markdown instead of Rich text. Can you confirm/disconfirm?

I tested this with Grammarly desktop and it seems to work with Rich text, though it's a bit flaky and I'll look into it at some point. It doesn't look like we're blocking it, though. It looks like Grammarly itself is struggling to identify nested contenteditable windows.

kfklein15 commented 10 months ago

Hi @SallyMcGrath , I have the same problem on both markdown and rich text: the changes from Grammarly aren't applied to it, so I have to re-type any change. I made this video, which hopefully helps explain it.

https://github.com/CodeYourFuture/CYF-PD/assets/80272258/d86deb39-ad0e-49d5-be0f-57263f7aa53b

SallyMcGrath commented 7 months ago

@kfklein15 Grammarly is working now on Decap 3 but not on nested editors. I am considering switching out Decap for another fork of the same code called Static CMS. Here's a preview #53

kfklein15 commented 7 months ago

Ok, I will then close this ticket since we'll follow it on 53.