CodeYourFuture / CYF-PD

Development Platform for PD team
https://cyf-pd.netlify.app/
Creative Commons Attribution 4.0 International
1 stars 5 forks source link

Mount main curriculum theme to PD #52

Closed SallyMcGrath closed 2 months ago

SallyMcGrath commented 7 months ago

This will show PD vols the layout of the curriculum.

There's a larger piece of work to do if we really want this, as the main theme expects linked blocks for PD, and we'd need to fix up the menus a bit, turn on search, etc. But here's a simple prototype to look at to see if we want this at all.

netlify[bot] commented 7 months ago

Deploy Preview for cyf-pd ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/cyf-pd/deploys/65c689f95189430ab45e56b8
Deploy Preview https://deploy-preview-52--cyf-pd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kfklein15 commented 7 months ago

Thaks, Sally. To confirm, it's just the first-page layout that has changed, nothing else, correct? The tests are failing. Should I approve it anyway?

SallyMcGrath commented 7 months ago

This changes the layout to show you what the PD block would look like in the main curriculum. The entire site is replaced, except the CMS view. As with all these previews, if you try to navigate by clicking links it will navigate out of the branch preview to the deployed site. You can get back to the preview version of any page by prepending deploy-preview-52- to the url.

Here are some direct links to example views:

Module / sprint view

https://deploy-preview-52--cyf-pd.netlify.app/modules/fundamentals/

block view

https://deploy-preview-52--cyf-pd.netlify.app/blocks/presenting-your-blockly-project/readme/

Daniel asked me if this was possible so I made this for you and your team to explore and think if it's helpful.

kfklein15 commented 7 months ago

It does look much nicer and makes sense, especially the module view ( https://deploy-preview-52--cyf-pd.netlify.app/modules/fundamentals/) But I also don't think this falls in the category of urgent, albeit important.

On Tue, 13 Feb 2024 at 13:09, Sally McGrath @.***> wrote:

This changes the layout to show you what the PD block would look like in the main curriculum. As with all these previews, if you try to navigate by clicking links it will navigate out of the branch preview to the deployed site. You can get back to the preview version of any page by prepending deploy-preview-52- to the url.

Here are some direct links to example views:

Module / sprint view

https://deploy-preview-52--cyf-pd.netlify.app/modules/fundamentals/

block view

https://deploy-preview-52--cyf-pd.netlify.app/blocks/presenting-your-blockly-project/readme/

Daniel asked me if this was possible so I made this for you and your team to explore and think if it's helpful.

— Reply to this email directly, view it on GitHub https://github.com/CodeYourFuture/CYF-PD/pull/52#issuecomment-1941481143, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATENXAWP6MTYTRRM4GBPF3LYTNQXXAVCNFSM6AAAAABDCABHGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRGQ4DCMJUGM . You are receiving this because your review was requested.Message ID: @.***>

SallyMcGrath commented 7 months ago

It does look much nicer and makes sense, especially the module view ( https://deploy-preview-52--cyf-pd.netlify.app/modules/fundamentals/) But I also don't think this falls in the category of urgent, albeit important.

It's not marked as urgent. Can you explain why you have said this?

kfklein15 commented 7 months ago

Because I don't think it is something urgent to do.

SallyMcGrath commented 2 months ago

feels like this is stale