CodeYourFuture / Module-HTML-CSS

The central repo for the HTML CSS module
https://cyf-module-html-css.netlify.app/wireframe/
Creative Commons Attribution 4.0 International
0 stars 36 forks source link

NW-6 | AREEB-SATTAR | HTML-CSS | [TECH ED] Cakes Co | WEEK-2 #143

Open areebsattar opened 8 months ago

areebsattar commented 8 months ago

Learners, PR Template

Self checklist

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

netlify[bot] commented 8 months ago

Deploy Preview for cyf-module-html-css ready!

Name Link
Latest commit 301da67dca984b97cebcd8e358d0e7cfee9f3ce3
Latest deploy log https://app.netlify.com/sites/cyf-module-html-css/deploys/652b00f5caba3600080fadd4
Deploy Preview https://deploy-preview-143--cyf-module-html-css.netlify.app/cakes-co
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

JayMayer commented 7 months ago

Great work Areeb! I can clearly see you have used a mobile-first approach to the design, and the site keeps all the relevant content visible on mobile, tablet, and desktop. Your images don't become distorted or squashed, they look delicious whatever the screen size! I also like how the menu bar continues to shift with the screen size on desktop to add some flair 😀

And fantastic work getting the hamburger menu to function, there's some great CSS selectors in there!

Aside from a few inline comments on code styling, I only want to comment on some places where the layout might need to be considered more closely. It's only a minor thing, but can sometimes make a site look less polished. For example, in the image below, the grid could be centred on the screen, with the top image aligning to the bottom images

image

Keep up the great work!