NW-6 | AREEB-SATTAR | HTML-CSS | Wireframe | WEEK-1

[areebsattar]

Learners, PR Template

Self checklist

• [ ] I have committed my files one by one, on purpose, and for a reason
• [ ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• [ ] I have tested my changes
• [ ] My changes follow the style guide
• [ ] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[netlify[bot]]

✅ Deploy Preview for cyf-module-html-css ready!

Name	Link
🔨 Latest commit	8bea34ad5e9097f35c0501c79b12d8fe929c8acb
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-module-html-css/deploys/6533b4eaca8e860008858b56
😎 Deploy Preview	https://deploy-preview-169--cyf-module-html-css.netlify.app/wireframe
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: Accessibility: Best Practices: SEO: PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JayMayer]

Looking good Areeb! I'm a huge fan of the colour scheme, looks great together.

Some small pointers you might consider for future HTML/CSS projects:

1. Currently the grid layout is explicitly defined for each article. That works fine right now, but imagine we needed to add another article to the page - it wouldn't know where to go. There are some tricks you can use with grid to have every article take up half of the space, except the first article which uses the :first-child selector with CSS properties to make it take up the whole width
2. Stick to only one <h1> heading per page. It's considered the "main title" of the page, so more than one can be confusing

[areebsattar]

That's definitely helpful to know, I remember we learned about these later after doing this project but thanks for reminding again