NW6 | Bakhat Begum| Module -JS2| Js2 reading list/week 3

BakhatBegum commented 5 months ago

Learners, PR Template

Self checklist

[x] I have committed my files one by one, on purpose, and for a reason
[x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x] I have tested my changes
[ ] My changes follow the style guide
[x] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Render the list of books on the page. Each book should have a title, author and image and a background colour that is set dependent on whether we have read the book or not.

.

netlify[bot] commented 5 months ago

Deploy Preview for cute-gaufre-e4b4e5 ready!

Name	Link
Latest commit	3c5e46f53559fbdef05c501b344a22c47db39d9d
Latest deploy log	https://app.netlify.com/sites/cute-gaufre-e4b4e5/deploys/65b6e0baddb4ec0008c9197f
Deploy Preview	https://deploy-preview-187--cute-gaufre-e4b4e5.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

BakhatBegum commented 5 months ago

Thank you very much for the feedback. I appreciate it. I made changes as per your feedback.

On Sun, 28 Jan 2024 at 21:12, Musa @.***> wrote:

@.**** commented on this pull request.

Overall great job @BakhatBegum https://github.com/BakhatBegum ! NB: your preview link doesn't work 👀

In week-3/reading-list/script.js https://github.com/CodeYourFuture/Module-JS2/pull/187#discussion_r1468937930 :

@@ -1,4 +1,17 @@ -// for the tests, do not modify this array of books +// // for the tests, do not modify this array of books + +function readingList(li) {

const shuffledBooks = [...li]; //the three dots is spread syntext that copy the shallow array.

Nice! well done

In week-3/reading-list/script.js https://github.com/CodeYourFuture/Module-JS2/pull/187#discussion_r1468938327 :

@@ -1,4 +1,17 @@ -// for the tests, do not modify this array of books +// // for the tests, do not modify this array of books + +function readingList(li) {

const shuffledBooks = [...li]; //the three dots is spread syntext that copy the shallow array.

for (let i = shuffledBooks.length - 1; i > 0; i--) {

const indexZ = Math.floor(Math.random() * (i + 1));

Again, don't be afraid to challenge yourself to come up with more descriptive names :) ,especially when it comes to calculations, etc shuffledBooks instead of indexZ

— Reply to this email directly, view it on GitHub https://github.com/CodeYourFuture/Module-JS2/pull/187#pullrequestreview-1847630807, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7AJUM27JE2YM25ZIHFTIN3YQ25LTAVCNFSM6AAAAABB2IR66WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBXGYZTAOBQG4 . You are receiving this because you were mentioned.Message ID: @.***>

CodeYourFuture / Module-JS2