CodeYourFuture / Module-JS2

The central repo for JS2
1 stars 32 forks source link

NW6| Bakhat Begum | MODULE-JS2 | Js quotes/week 3 | WEEK-3 #189

Open BakhatBegum opened 5 months ago

BakhatBegum commented 5 months ago

Learners, PR Template

Self checklist

Changelist

When the page loads it should show a random quote from the quotes array on the screen. It should also show who said the quote.

When you click a button on the screen it should change the quote on the screen.

Questions

Is it good practice to do style in CSS?

netlify[bot] commented 5 months ago

Deploy Preview for cute-gaufre-e4b4e5 ready!

Name Link
Latest commit 58c13c6ebfaddd9d3bea8fce6459e868795f2d61
Latest deploy log https://app.netlify.com/sites/cute-gaufre-e4b4e5/deploys/65b6f500272ea900084761d8
Deploy Preview https://deploy-preview-189--cute-gaufre-e4b4e5.netlify.app/week-3/quote-generator
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

BakhatBegum commented 5 months ago

Thank you very much for your feedback. I made changes as per your feedback.

On Sun, 28 Jan 2024 at 20:52, Musa @.***> wrote:

@.**** commented on this pull request.

In week-3/quote-generator/index.html https://github.com/CodeYourFuture/Module-JS2/pull/189#discussion_r1468933814 :

 <p id="author"></p>
+

It's great to see that you're using semantic elements like

,

,

, and