Open BakhatBegum opened 5 months ago
Name | Link |
---|---|
Latest commit | 58c13c6ebfaddd9d3bea8fce6459e868795f2d61 |
Latest deploy log | https://app.netlify.com/sites/cute-gaufre-e4b4e5/deploys/65b6f500272ea900084761d8 |
Deploy Preview | https://deploy-preview-189--cute-gaufre-e4b4e5.netlify.app/week-3/quote-generator |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thank you very much for your feedback. I made changes as per your feedback.
On Sun, 28 Jan 2024 at 20:52, Musa @.***> wrote:
@.**** commented on this pull request.
In week-3/quote-generator/index.html https://github.com/CodeYourFuture/Module-JS2/pull/189#discussion_r1468933814 :
<p id="author"></p>
It's great to see that you're using semantic elements like , and In week-3/quote-generator/quotes.js
https://github.com/CodeYourFuture/Module-JS2/pull/189#discussion_r1468934881
: @@ -25,469 +25,509 @@ function pickFromArray(choices) {
const quotes = [
{
quote: "Life isn't about getting and having, it's about giving and being.", Instead of manually adding the dash ("-") to each quote in the array, you
could use JS to insert it into your HTML code dynamically :) quoteParagahraph2.innerText = In week-3/quote-generator/quotes.js
https://github.com/CodeYourFuture/Module-JS2/pull/189#discussion_r1468935330
: +const quoteParagahraph2 = document.getElementById("author");
+quoteParagahraph2.innerText = currentQuote.author; In week-3/quote-generator/quotes.js
https://github.com/CodeYourFuture/Module-JS2/pull/189#discussion_r1468935693
: +
+function getQoutes(evet){
+const quoteParagahraph = document.getElementById("quote");
+const currentQuote = pickFromArray(quotes);
+quoteParagahraph.innerText = currentQuote.quote;
+const quoteParagahraph2 = document.getElementById("author");
+quoteParagahraph2.innerText = currentQuote.author;
+
+}
+getQoutes();
+
+const button = document.getElementById("new-quote");
+function eventhandler(event){ In week-3/quote-generator/style.css
https://github.com/CodeYourFuture/Module-JS2/pull/189#discussion_r1468935869
: Your preview looks great! Well done @BakhatBegum
https://github.com/BakhatBegum ! —
Reply to this email directly, view it on GitHub
https://github.com/CodeYourFuture/Module-JS2/pull/189#pullrequestreview-1847626735,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7AJUM5SC3FO3EZ3OZMIM7LYQ227NAVCNFSM6AAAAABB2JYA2KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBXGYZDMNZTGU
.
You are receiving this because you were mentioned.Message ID:
@.***>
,
- ${currentQuote.author}
;By using JS to handle the quote and formatting, your code becomes more
flexible and easier to maintain!
Great job! In the future, consider using more meaningful variable names
like authorName for better clarity and readability.
While console logs can be helpful during development and debugging, they
are typically not necessary in the final version of the code. It would be
helpful to remove the console log statements before submitting your code!
Learners, PR Template
Self checklist
Changelist
When the page loads it should show a random quote from the
quotes
array on the screen. It should also show who said the quote.When you click a button on the screen it should change the quote on the screen.
Questions
Is it good practice to do style in CSS?