London | Mohammed Aslam | Form Control

mohammed22471 commented 3 days ago

Learners, PR Template

Self checklist

[✔️ ] I have committed my files one by one, on purpose, and for a reason
[ ✔️] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[ ✔️] I have tested my changes
[ ]✔️ My changes follow the style guide
[✔️ ] My changes meet the requirements of this task

I have uploaded my form control files.

I have made changes to my first project wire-frame and I was wondering if its ok.

netlify[bot] commented 3 days ago

Name	Link
Latest commit	9497d84ca98c79284e7074e94a07aa4d149be06f
Latest deploy log	https://app.netlify.com/sites/cyf-ufd/deploys/67153938a7c7b10008a8962a
Deploy Preview	https://deploy-preview-262--cyf-ufd.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 Accessibility: 100 Best Practices: 100 SEO: 91 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

maesierra commented 2 days ago

Hi. Congrats on your work. It captures quite well the requirements. But there are 2 small issues.

You can pick any date. The exercise ask you to restrict the date to allow only a date in the next 4 weeks. I'd suggest you to look at the options for <input type="date" />" You can find information about it here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date
The expression you're using to validate the name it's too strict :cry: I cannot even type my own name because it has non-English characters and I'm sad when a form doesn't allow me to use it. Also your expression allows your name to have just one character. I the requirements, it says a name should at least have 2 characters.