CYF-ITP-South Africa Natalie Patel| Module-User-Focused-Data Form Controls

NataliePatel commented 1 day ago

Self checklist

[x] I have committed my files one by one, on purpose, and for a reason
[x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x] I have tested my changes
[x] My changes follow the style guide
[x] My changes meet the requirements of this task

Changelist

I have created an order form for t-shirts that have the following specifications:

Customer name
Customer email address
Colour selection from 3 possible colours only
Size selection from 6 possible sizes only
Delievery date selection only within a time-range for the next 4 weeks from today's date 21 October 2024.
Fields are marked as required
For and Id fields have been included for accessibility, name for back-end data storage
Comments in code have been included to help identify each element

Ask any questions you have for your reviewer.

netlify[bot] commented 1 day ago

Name	Link
Latest commit	2be70ffac29cff1756b3b947085e6a8caf36c657
Latest deploy log	https://app.netlify.com/sites/cyf-ufd/deploys/67164a8976c82f00089cd706
Deploy Preview	https://deploy-preview-274--cyf-ufd.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Waldo-Strydom commented 9 hours ago

Hi @NataliePatel, good job, but you need to get your accessibility score to 100. Please improve the following.

Form elements do not have associated labels

Heading elements are not in a sequentially-descending order