CYF London | Rihanna Poursoltani | Module User Focused Data | Form controls | Week 2 - Githubissues

CodeYourFuture / Module-User-Focused-Data

Introduction to Programming #1

Creative Commons Attribution 4.0 International

1 stars 96 forks source link

CYF London | Rihanna Poursoltani | Module User Focused Data | Form controls | Week 2 #279

Open RihannaP opened 4 hours ago

RihannaP commented 4 hours ago

Learners, PR Template

Self checklist

[x] I have committed my files one by one, on purpose, and for a reason
[x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x] I have tested my changes
[x] My changes follow the style guide
[x] My changes meet the requirements of this task

Changelist

Added valid inputs with associated labels for name, email, radio, date and select.All of inputs are required.
My Lighthouse Accessibility score (for Desktop and Mobile) is 100.
Added 6 options for size with select and 3 options for colours with using fieldset and radio inputs.
Adde two buttons for submit and reset.
Added style, hover and focus for labels, inputs and buttons.

Questions

I had problem for setting size for select option. As you can see width is not the same as others in the page.How can I fix that?

Ask any questions you have for your reviewer.

netlify[bot] commented 4 hours ago

Deploy Preview for cyf-ufd ready!

Name	Link
Latest commit	7ab9d73629d6bfe253a1d6c518aab38ae65637b9
Latest deploy log	https://app.netlify.com/sites/cyf-ufd/deploys/67176b2da3b57600084cc219
Deploy Preview	https://deploy-preview-279--cyf-ufd.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.