South Africa ITP | Emmanuel Siziba | Module-User-Focussed

CodeYourFuture / Module-User-Focused-Data

Introduction to Programming #1

Creative Commons Attribution 4.0 International

1 stars 103 forks source link

Closed EmmanuelSiziba closed 3 weeks ago

EmmanuelSiziba commented 4 weeks ago

Self checklist

[x] I have committed my files one by one, on purpose, and for a reason
[x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x] I have tested my changes
[x] My changes follow the style guide
[x] My changes meet the requirements of this task

Briefly explain your PR.

Ask any questions you have for your reviewer.

netlify[bot] commented 4 weeks ago

Name	Link
Latest commit	892878e224c34b896975d3e96c90c32962fd1d8b
Latest deploy log	https://app.netlify.com/sites/cyf-ufd/deploys/6728c217651b450008da4ae4
Deploy Preview	https://deploy-preview-301--cyf-ufd.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cjyuan commented 3 weeks ago

This is the URL to your deployed webpage: https://deploy-preview-301--cyf-ufd.netlify.app/wireframe/ The page does not look like the wireframe.
The footer is not fixed at the bottom of the viewport (browser window). Supposedly it should not move when the page is scrolled.
The area with a cross in the wireframe represents an image. Can you add images to your page to make the page look more like the wireframe?
Using <br> to create gap makes setting an exact amount of vertical space difficult. For example, what if you want to keep 1.8rem between the summary and the link? There are better ways to create space around elements.
May I suggest using a HTML validator such as https://validator.w3.org/ to help yourself identify potential error in HTML?

EmmanuelSiziba commented 3 weeks ago

Hi @cjyuan I have fixed my project please find the pull request link above