CodeYourFuture / curriculum

The CYF Curriculum
https://curriculum.codeyourfuture.io
Other
34 stars 46 forks source link

Tabs Have Got To Go #1068

Open SallyMcGrath opened 1 month ago

SallyMcGrath commented 1 month ago

Describe the bug

Our tabs are fragile and terrible and break in so many ways. Let us count the ways!

  1. The double markdown render loop breaks some rendering in unpredictable ways #954 #76 #245 #288 #145 ...
  2. The html is fine but we probably should move to inert now it's in baseline
  3. The web component might not be necessary any more
  4. It's possible to write broken tabs #1067
  5. The markup is cumbersome and I always forget it
  6. Add your hatred and grievances here if there's room after all mine

What is wrong with this content?

☝️ How could this be fixed?

Write new tabs. We foolishly re-used Kubernetes/Docsy tabs and this is the source of our pain.

Replace the old markup too maybe

Link to content

Additional context

Who else might need to know about this?

SallyMcGrath commented 1 week ago

https://github.com/CodeYourFuture/curriculum/tree/feature/1068-new-tabs