CodeYourFuture / curriculum

The CYF Curriculum
https://curriculum.codeyourfuture.io
Other
34 stars 46 forks source link

1001 Bug: readme links not being cleaned #1139

Closed SallyMcGrath closed 3 weeks ago

SallyMcGrath commented 3 weeks ago

What does this change?

As per #1001, adds a new strings util to transform github readme api paths.

I've changed the format of a link on ITP> UFD > 1 > Dayplan to show this. This is how it worked before we broke it at some point, but I've done it in a more robust way now - I've hived it off into a separate, well commented partial that the data partial can call.

It is probably desirable to do this with most of the string transforms over time.

Common Theme?

Fixes #1001 readme regex

Issue number: #issue-number

Org Content?

UFD | 1 | Dayplan | Workshop

Checklist

Who needs to know about this?

netlify[bot] commented 3 weeks ago

Deploy Preview for cyf-tracks ready!

Name Link
Latest commit d22aa9d4a6aad20958aa6137882bd0cb8baf9f18
Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/671e036236b5430008bcae48
Deploy Preview https://deploy-preview-1139--cyf-tracks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for cyf-programming ready!

Name Link
Latest commit d22aa9d4a6aad20958aa6137882bd0cb8baf9f18
Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/671e036216a125000859de7b
Deploy Preview https://deploy-preview-1139--cyf-programming.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for cyf-launch ready!

Name Link
Latest commit d22aa9d4a6aad20958aa6137882bd0cb8baf9f18
Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/671e03627c472600082af32f
Deploy Preview https://deploy-preview-1139--cyf-launch.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for cyf-sdc ready!

Name Link
Latest commit d22aa9d4a6aad20958aa6137882bd0cb8baf9f18
Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/671e03626e5ae400084c4fc4
Deploy Preview https://deploy-preview-1139--cyf-sdc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SallyMcGrath commented 3 weeks ago

Seems reasonable - thanks!

I hate regex so much, Daniel! I can't understand it no matter how hard I try. So I need to write it out in excruciating detail every time. 🫠