netlify[bot]
commented
3 weeks ago Deploy Preview for cyf-programming ready!
| Name | Link |
|---|---|
| Latest commit | 3a381b2e5eedf63e3332c8433514324240a46d5f |
| Latest deploy log | https://app.netlify.com/sites/cyf-programming/deploys/671f8a83bee54d0008666be6 |
| Deploy Preview | https://deploy-preview-1143--cyf-programming.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
What does this change?
This is a surprisingly large change, as discussed with @illicitonion. Instead of continuing to hack the wrapping directory for sprints, I have removed that directory. This means all the links lose the /sprints/ level. so we need to decide what we want to do.
I set it up to try to control something we no longer need to do because Hugo has build settings and module mounts and we can use (and are using) all that instead.
So I've unwrapped all the sprints into their parent directory and used the basic "local navigation" feature in Hugo https://gohugo.io/methods/pages/prev/
I also can now rm all the manual reversing and just reverse on the partial.
So really all you need to look at in this 211 file behemoth are these two files
https://github.com/CodeYourFuture/curriculum/pull/1143/files?file-filters%5B%5D=.html&show-viewed-files=true
Common Theme?
Fixes #1058 sprint nav
Org Content?
all the hugo.tomls all the /sprints folders
⚠️ THIS BREAKS ALL THE LINKS DON'T MERGE IT YET
Checklist
Who needs to know about this?