CodeYourFuture / curriculum

The CYF Curriculum
https://curriculum.codeyourfuture.io
Other
34 stars 45 forks source link

Content: Data Flows : TV Show #1189

Open SallyMcGrath opened 1 week ago

SallyMcGrath commented 1 week ago

What does this change?

Just closing down my tabs - here's the TV show project re-added to the website and renamed according to the project naming convention.

Org Content?

Data Flows | 1-3 | Project

Checklist

Who needs to know about this?

netlify[bot] commented 1 week ago

Deploy Preview for cyf-curriculum canceled.

Name Link
Latest commit 51505c6a56f91192d441d5b87e78e25bc0170734
Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/672fa4a42c4a0700087cd3c4
netlify[bot] commented 1 week ago

Deploy Preview for cyf-tracks ready!

Name Link
Latest commit 51505c6a56f91192d441d5b87e78e25bc0170734
Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/672fa4a4c08968000820372e
Deploy Preview https://deploy-preview-1189--cyf-tracks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for cyf-programming ready!

Name Link
Latest commit 51505c6a56f91192d441d5b87e78e25bc0170734
Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/672fa4a493f1d80008dea3b8
Deploy Preview https://deploy-preview-1189--cyf-programming.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (🟢 up 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for cyf-sdc ready!

Name Link
Latest commit 51505c6a56f91192d441d5b87e78e25bc0170734
Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/672fa4a4378865000815ee9b
Deploy Preview https://deploy-preview-1189--cyf-sdc.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for cyf-common canceled.

Name Link
Latest commit 51505c6a56f91192d441d5b87e78e25bc0170734
Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/672fa4a4e93188000869b52c
netlify[bot] commented 1 week ago

Deploy Preview for cyf-itd ready!

Name Link
Latest commit 51505c6a56f91192d441d5b87e78e25bc0170734
Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/672fa4a41dc7d90008b6e4d4
Deploy Preview https://deploy-preview-1189--cyf-itd.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 91 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for cyf-piscine ready!

Name Link
Latest commit 51505c6a56f91192d441d5b87e78e25bc0170734
Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/672fa4a44714290008a22534
Deploy Preview https://deploy-preview-1189--cyf-piscine.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 97 (🟢 up 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for cyf-launch ready!

Name Link
Latest commit 51505c6a56f91192d441d5b87e78e25bc0170734
Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/672fa4a44ded070008488d67
Deploy Preview https://deploy-preview-1189--cyf-launch.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

illicitonion commented 1 week ago

I'm not sure about this... This feels like something we could maybe do by applying tags to existing backlog items (to extract the pieces), rather than duplicating?

Currently this PR duplicates what you're meant to do each sprint between the module tickets (e.g. https://github.com/CodeYourFuture/Module-Data-Flows/issues/46) and the project tickets (e.g. https://github.com/CodeYourFuture/Project-TV-Show/issues/9)

I feel like either we should reference the project tickets in the sprint backlog, or we should reference the module tickets, but not both.

Concretely, if we move Level 200 back to sprint 1, I only want to be modifying that in one place not two.

SallyMcGrath commented 3 days ago

I'm not sure about this... This feels like something we could maybe do by applying tags to existing backlog items (to extract the pieces), rather than duplicating?

Currently this PR duplicates what you're meant to do each sprint between the module tickets (e.g. CodeYourFuture/Module-Data-Flows#46) and the project tickets (e.g. CodeYourFuture/Project-TV-Show#9)

I feel like either we should reference the project tickets in the sprint backlog, or we should reference the module tickets, but not both.

Concretely, if we move Level 200 back to sprint 1, I only want to be modifying that in one place not two.

It references the tickets using sprint filters, so if you update the label, it moves by itself. It's not duplicating - it mirrors the project. Can you say a bit more, because to me it sounds like your solution is this already?

Edited! OK now I see what you're saying. You're not talking about the content in this PR, you're talking about the tickets between the module and the project repo. These tickets are the original tickets - they already existed - so I didn't pick up what you meant.

It sounds like you're wondering whether we need the module tickets sending them to the project tickets. We have it that way because trainees felt it wasn't clear what to do when and asked for both sets. They liked the TV show project being a separate understandable thing - this came up in feedback a few times - but mentors worried they would miss the coursework if it wasn't spelled out on the main repo too.

I actually have a preference for fewer tickets myself, but I'd keep the project tickets and dump the module ones. This would be vastly easier for maintenance and for lower context volunteers. What do you think?

illicitonion commented 1 day ago

I think we agreed to block this on https://github.com/CodeYourFuture/curriculum/issues/1204 but let me know if that's not how you felt we concluded!

SallyMcGrath commented 23 hours ago

I think we agreed to block this on #1204 but let me know if that's not how you felt we concluded!

Yep, we have blocked