search

CodeYourFuture / curriculum

The CYF Curriculum
https://curriculum.codeyourfuture.io
Other
28 stars 32 forks source link

Don't intentionally throw away case of menu items #909

Open illicitonion opened 1 week ago

illicitonion commented 1 week ago

I'm not sure why all Table of Contents entries in the solo view are forcibly lower-cased.

This line here does it: https://github.com/CodeYourFuture/curriculum/blob/e498be92579787aace42d95ddeccddcc24e5a9ac/common-theme/assets/styles/04-components/toc.scss#L26

I'm quite tempted to remove it - I think the forcible lower-casing looks kind of weird.

Is there a strong reason for this? I'm happy to remove it, and go through fixing up the case of things that were written expecting case not to matter, if there's no big argument against!

SallyMcGrath commented 4 days ago

It's not good to have them mixed and most people were lowercasing. If you want to title case you can, text-transform: capitalize; but please give us a clean scanning line down the menu, upper or lower.

Will leave the decision in your hands!

SallyMcGrath commented 1 day ago

Connected to #984