CodeYourFuture / curriculum

The CYF Curriculum
https://curriculum.codeyourfuture.io
Other
28 stars 32 forks source link

Tidy up emojis #984

Open SallyMcGrath opened 1 week ago

SallyMcGrath commented 1 week ago

A poem by Sally aged 41 and three quarters

We have emojis used really inconsistently. Each block has an emoji param, but Instead of showing that in the front end, it's often skipped For this reason, I think, users have hardcoded emojis into titles But not all users...

So sometimes there are emojis in titles and sometimes not And sometimes the emojis in the side menu on the prep view are there and sometimes not. So it looks a mess And it breaks scanlines

I think we always want an emoji to identify a block And this emoji should be consistent

But this is a really boring job! It means going through each block and moving the hardcoded emoji into the emoji param And then calling that emoji in these contexts:

local block titles
table of contents titles
overview page titles
probably search results titles

OK maybe it's not a poem, but it's still something worth doing

SallyMcGrath commented 2 days ago

I would take any number of PRs on this ticket -- if you just want to do 1 misplaced emoji that would be helpful. Many hands!

fcaroline2020 commented 1 day ago

Before I continue, can you have a look if I am doing this correctly @SallyMcGrath

SallyMcGrath commented 1 day ago

Fab, thank you!