search

CodeYourFuture / syllabus-archive

[ARCHIVED] Please use https://github.com/CodeYourFuture/syllabus
https://codeyourfuture.github.io/syllabus-master
74 stars 116 forks source link

React use effect #415

Closed LucyMac closed 4 years ago

LucyMac commented 4 years ago

Adds useEffect for mounting to week 2 (for data fetches), and useEffect for updating to week 3.

May need some more fleshing out, and probably needs some exercises attached to these, but wanted to get initial feedback.

@40thieves it would also be super helpful to see the changes you've been making as there are mentions of classes throughout and most examples use class syntax.

40thieves commented 4 years ago

@LucyMac I took the liberty of rebasing (well, actually cherry-picking was easier) your branch onto master.

40thieves commented 4 years ago

@LucyMac I'm going to go ahead and merge this now. We can follow up later with the suggested fixes.