CodeYourFuture / syllabus

Old Syllabus Website for CodeYourFuture
https://syllabus.codeyourfuture.io
154 stars 124 forks source link

jest --testPathIgnorePatterns containing pipes appears to break Windows #306

Open illicitonion opened 3 years ago

illicitonion commented 3 years ago

See https://codeyourfuture.slack.com/archives/C01V4EULPTM/p1626618958485700

It looks like using pipes in regexes is breaking running jest on Windows, as the shell is interpreting them as shell pipes rather than part of a regex... Not sure what's going on or why, but given how prevalent Windows is in our trainees we definitely need to resolve this somehow.

/cc @gregdyke

ChrisOwen101 commented 3 years ago

Anecdotally - I've been running these commands on Windows fine. As a stop gap, could you ask the students to Git Bash @illicitonion

Dominic-Taylor-Dev commented 3 years ago

As an interim solution, I told the folks having problems to replace package.json with this (all three of them said it then worked fine):

{
  "name": "javascript-core-2-coursework-week1",
  "version": "1.0.0",
  "description": "Exercises for JS2 Week 1",
  "scripts": {
    "test": "jest"
  },
  "repository": {
    "type": "git",
    "url": "git+https://github.com/CodeYourFuture/JavaScript-Core-2-Coursework-Week1.git"
  },
  "bugs": {
    "url": "https://github.com/CodeYourFuture/JavaScript-Core-2-Coursework-Week1/issues"
  },
  "jest": {
    "setupFilesAfterEnv": [
      "jest-extended",
      "./.setup/jest.setup.js"
    ],
    "testPathIgnorePatterns": [
      "<rootDir>/mandatory/choose-your-own", 
      "<rootDir>/mandatory/recipes",
      "<rootDir>/mandatory/water-bottle",
      "<rootDir>/node_modules/"
    ],
    "testRegex": [
      "mandatory[/\\\\].*\\.js$"
    ]
  },
  "homepage": "https://github.com/CodeYourFuture/JavaScript-Core-2-Coursework-Week1#readme",
  "devDependencies": {
    "jest": "^26.6.3",
    "jest-extended": "^0.11.5"
  },
  "licence": "CC-BY-4.0"
}
Dominic-Taylor-Dev commented 3 years ago

(my reasoning being that it seems Windows doesn't like the pipes, but that's not the documented way to use testPathIgnorePatterns anyway in Jest)

SallyMcGrath commented 1 year ago

probably obsoleted by us banning windows #340