search

CodeYourFuture / syllabus

Old Syllabus Website for CodeYourFuture
https://syllabus.codeyourfuture.io
154 stars 124 forks source link

Style guide violation, please update #569

Open SallyMcGrath opened 1 year ago

SallyMcGrath commented 1 year ago

https://github.com/CodeYourFuture/syllabus/blob/02da63dbe1a20f8df0559074f4dac810e8af62a8/docs/workshops/js-testing-workshop.md?plain=1#L54

Improper use of var

https://syllabus.codeyourfuture.io/guides/code-style-guide

Please update to follow our own advice

MohitBansal321 commented 1 year ago

what can we use instead of var?

SallyMcGrath commented 1 year ago

what can we use instead of var?

let

MohitBansal321 commented 1 year ago

i created a pull request

MohitBansal321 commented 1 year ago

I changed all var to let according to style guide @SallyMcGrath please let me know how is it