CodeYourFuture / tech-products-demo

Example app for tech products interview experiment
https://tech-products-demo-d1182e30f280.herokuapp.com/
ISC License
3 stars 20 forks source link

Show users their own resources #34

Closed Emmanuel-Dominic closed 8 months ago

Emmanuel-Dominic commented 9 months ago

This is a:

Description

Author checklist

Emmanuel-Dominic commented 8 months ago

Hello @textbook, Thanks for your feedback, however, I would like to clarify this statement for clarity

I wonder if it would be helpful to indicate that a resource is a draft more explicitly than just showing the publish button? The other place we show draft resources is they're explicitly on the drafts page (and remember admins would stop seeing drafts here with issue #11, but non-admins would start seeing drafts with issue #15).

So, is my picked up issue #12 intended to cover issue #11 while leaving room for the implementation of issue #15 or should it be treated as a standalone issue leaving room for both issues #11 and #15 to be addressed?

textbook commented 8 months ago

Specifically within this story as proposed, per the pictures I shared above: it's implicit to the admin users that some of the resources they're seeing are drafts, because they have a publish button. So I wonder, right now, if that should be made explicit or whether we can rely on them to figure it out (or immediately publish their own resources so never see drafts here, or simply not care, etc.). I mention the other two stories because we should always think about our work in context, to help make the best decisions - if we delivered #11 (so admins don't see drafts) but never #15 (so non-admins don't see them either) then we'd never see drafts in this view at all, for example.

Emmanuel-Dominic commented 8 months ago

Hello @textbook, thank you for providing this insight

💡 As I see it, it makes sense, since I buy the idea of returning the user data with the loadingMore option, while displaying only the most recent resources without passing the pagination parameter to the URL.

textbook commented 8 months ago

No problem! If you'd like to work on this further that's great, it's all good practice, but for the Tech Products interview process just focus on getting the pipeline to ✅