search

CodeZombie / TypeRip

Adobe Fonts (formerly TypeKit) font ripper
http://badnoise.net/TypeRip/
352 stars 62 forks source link

Missing font names when downloading without processing #15

Open gingerbeardman opened 3 years ago

gingerbeardman commented 3 years ago

Reproduce

  1. https://fonts.adobe.com/fonts/bebas-neue-pro
  2. check "download without processing"
  3. I get missing name for all fonts:
Screen shot 2021-05-31 at 21 59 21

Workaround

gingerbeardman commented 3 years ago

Ah, I see in the readme:

Added the option to download fonts without processing. This is useful if your download hangs and/or crashes your browser. Downloading the fonts without processing will always work, but you will have to edit the fonts manually to change their names and ensure compatibility with your OS.

CodeZombie commented 3 years ago

Downloading without processing should only be used in cases where Typerip crashes while trying to download a font file. This happens because the font contains some data that Opentype.js isn't expecting, causing the browser to hang resulting in a crash.

Opentype.js is used to rebuild the font file, because the raw files from the adobe server are basically unusable outside of browsers as they're missing the font name and important pieces of data that windows and macos can't seem to parse.

I'm still looking into why this crash is occurring, but mostly focusing on trying to find a replacement for Opentype as I've already had to make modifications to the library to get it to work at all, and I'm losing faith in its ability to be useful for rebuilding fonts in this project.

I should add an explanation in the main tool that tells you what "Download without processing" does though, as users shouldn't need to look at the readme to figure out what its used for.

If you download the fonts with processing do they install correctly? I grabbed a few font files just now and they seem to work fine on windows.

gingerbeardman commented 3 years ago

Yes, with processing they install fine