search

CodeZombie / TypeRip

Adobe Fonts (formerly TypeKit) font ripper
http://badnoise.net/TypeRip/
352 stars 62 forks source link

Fixed repeated style names issue #22

Open Phrixus73 opened 2 years ago

Phrixus73 commented 2 years ago

Please try it here

Somehow managed to fix the repeated style names issue which was causing a problem whilst installing the ripped fonts. Now it is able to differentiate between weights such as 'regular' and 'regular italic' both which previously were recognized as 'regular' leading to the 'Font regular is already installed' error. However I was not able to set separate values for styles such as 'expanded', 'semi-expanded', 'condensed', etc. Iam working on it and will try to fix it soon.

CodeZombie commented 2 years ago

This looks really good! Merging the Font Family Name with the Style Name will definitely resolve any duplicate-font-name issues.

What was the reason for replacing the || " " with || "" (effectively removing default whitespace) in the property names? From the comment in opentype.js, this was done for Mac OS compatibility.

Also, why change the Units Per Em to 1024 from 1000?

madmaximux commented 1 year ago

@Phrixus73 Any update on this?