CodeZombie / TypeRip

Adobe Fonts (formerly TypeKit) font ripper
http://badnoise.net/TypeRip/
352 stars 62 forks source link

Fix error of Windows not classifying font styles #38

Closed tungwoodboi closed 6 months ago

tungwoodboi commented 6 months ago

Windows uses meta/head/macStyle to classify font styles. (Regular/ Italic/ Bold...) (https://learn.microsoft.com/en-us/typography/opentype/spec/head)

So I just tried to keep the original macStyle value in meta/head. Tested with some fonts I needed to use and they worked fine. (Phototop & Illustator)

tungwoodboi commented 6 months ago

try it here https://typerip.htdesignz.net/

CodeZombie commented 6 months ago

Excellent PR, thank you for digging through the spec and finding this! I also appreciate the unitsPerEm change, great find.

Merged :)