CodeZombie / TypeRip

Adobe Fonts (formerly TypeKit) font ripper
http://badnoise.net/TypeRip/
387 stars 65 forks source link

"Download All" fonts does not always download all fonts. #40

Open CodeZombie opened 8 months ago

CodeZombie commented 8 months ago

Thanks to @Nickyg001 for raising this issue,

Problem Description

clicking "Download All" on larger font families, specifically https://fonts.adobe.com/fonts/quasimoda will not download all fonts.

This issue does not appear to be present on Firefox, which successfully downloads all fonts, leading me to believe the file-saver npm module TypeRip is using has an existing bug related to chrome.

Notes

There's some mention in file-saver's github issues about this or a similar bug being present and fixed in 2018. I would imagine this fix has made its way up to whatever version I'm using now, but I'll have to do some more poking around to see if a fix is available on any version, or if perhaps this is a regression.

hannahroksanne commented 4 months ago

Came to report this, myself.

CleanShot 2024-05-23 at 17 26 58

I am working on building this functionality into a more featureful tool. If this is no longer maintained, I will link to my progress when it is ready to consume.

hannahroksanne commented 4 months ago

In the meantime, try this:

(() => {
    const buttons = $$('.ion-md-arrow-down')

    for (const button of buttons) {
        button.click()
    }
})()

Create a script in devtools. And just run it every time you load fonts into TypeRip.

CleanShot 2024-05-23 at 17 49 42@2x

bugproof commented 2 weeks ago

I converted typerip to rust simple standalone console app:

Tested font with the issue and it downloaded all fonts

https://github.com/bugproof/typerip-rs

@hannahroksanne

May further improve the tool for better organization e.g. will download both woff2 and ttf to /fonts/Quasimoda

To use just download rust:

cargo build -r

and then use the binary