CodeandoMexico / reporte-ciudadano

La plataforma de código abierto para la gestión de reportes ciudadanos.
Other
19 stars 26 forks source link

Integration tests #115

Closed juanpabloe closed 11 years ago

juanpabloe commented 11 years ago

spec/integration.

Cover feature's integration with Request Specs from Rspec. https://www.relishapp.com/rspec/rspec-rails/docs/request-specs/request-spec http://railscasts.com/episodes/257-request-specs-and-capybara

Try to cover all major features integration.

defvol commented 11 years ago

cucumber is neat http://cukes.info/

chillicoder commented 11 years ago

I see cucumber as a tool when there are non-programming stakeholders in the project, the definition of scenarios and such helps them to define what they really need. As this case where everybody is hackerish guy, don´t see where the value could come from, the rspec integration tests seems to be a better option

On Mon, Aug 26, 2013 at 10:06 PM, Rod Wilhelmy notifications@github.comwrote:

cucumber is neat http://cukes.info/

— Reply to this email directly or view it on GitHubhttps://github.com/CodeandoMexico/reporte-ciudadano/issues/115#issuecomment-23310362 .

kurenn commented 11 years ago

I think using just capybara would be the right option, as @chillicoder said, it's a more hacker project, just saying!

chillicoder commented 11 years ago

@juanpabloe hi, any advance with this? i'm willing to contribute with this issue but want to know if you already started

juanpabloe commented 11 years ago

@chillicoder hey! really great that you're contributing with the project.

The plan is to try to cover most of the existing code right now that have no specs, rather than new features yet. We mapped this on the Specs & tests milestone.

Me and @eddie-ruva planned to go with models and controllers first, then go with integration specs of existing features, which specs would you like to help us with?

chillicoder commented 11 years ago

Hi, glad you like it.

So, the admin model specs are almost ready, what models haven't been spec'ed by now? Which ones are you working on?

juanpabloe commented 11 years ago

We haven't started. You could take over models and we go over controllers, then we share the integration specs, What do you think?

We will start tomorrow.

On Sep 24, 2013 2:11 PM, "Martin Trejo" <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>> wrote:

Hi, glad you like it.

So, the admin model specs are almost ready, what models haven't been spec'ed by now? Which ones are you working on?

— Reply to this email directly or view it on GitHubhttps://github.com/CodeandoMexico/reporte-ciudadano/issues/115#issuecomment-25033690 .

chillicoder commented 11 years ago

I'd rather suggest to complete model specs first, as they're required in any testing done afterwards.

I'm glad to contribute but please be forgiving with my timing ;)

Saludos,

On Sep 24, 2013, at 3:13 PM, juanpabloe notifications@github.com wrote:

We haven't started. You could take over models and we go over controllers, then we share the integration specs, What do you think?

We will start tomorrow.

On Sep 24, 2013 2:11 PM, "Martin Trejo" <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>> wrote:

Hi, glad you like it.

So, the admin model specs are almost ready, what models haven't been spec'ed by now? Which ones are you working on?

— Reply to this email directly or view it on GitHubhttps://github.com/CodeandoMexico/reporte-ciudadano/issues/115#issuecomment-25033690 .

  • Juan Pablo Escobar L. Codeando México — Reply to this email directly or view it on GitHub.
juanpabloe commented 11 years ago

Cool. Then we will complete model specs between tomorrow and friday and you can pick new specs afterwards. Don't worry about timing, it's already really nice to have you contributing :+1:

Saludos