search

Codecademy / docs

Codecademy Docs is a collection of information for all things code. 📕
https://www.codecademy.com/resources/docs
771 stars 3.48k forks source link

[Edit] CSS [Edit] CSS Typography: text-decoration #4419

Open codecademy-docs opened 7 months ago

codecademy-docs commented 7 months ago

Type of Edit (select all that apply)

Add new content (definitions, codeblocks, etc.)

Description (optional)

We would like an edit to a term within CSS text-decoration. The term entry lives in content/css/concepts/typography/terms/text-decoration/text-decoration.md

Please refer to the term entry templates, content standards, and markdown style guide when working on the PR for this issue.

Please: 1) Add supplemental media (preferred .png or .gif, <1MB). 2) Media (images, gifs) should accurately represent the existing code blocks in the example sections and fit in-line. ex: See last image here

Code of Conduct

For Maintainers

dancikmad commented 7 months ago

Hi, I finished my working on 2 of my issues assigned.

I would love to work on this issue.

kamlesh-ops commented 7 months ago

Hii Can I take up this issue?

ishg-153 commented 7 months ago

@dancikmad You're assigned!🎉You can look through the Contribution Guide to know more about contributing to Codecademy Docs. Check out the Content Standards and Style Guide, they’ll help you with creating your entry.

ishg-153 commented 7 months ago

@kamlesh-ops , @dancikmad was here first.

Vishal-5121 commented 7 months ago

Hi, I finished my working on 2 of my issues assigned.

VeraLK commented 6 months ago

Hey there! Can I work on this issue please?

dancikmad commented 6 months ago

@ishg-153 Hi, I am finished with the task. I probably will create a PR tonight that closes this issue

mark1usya commented 5 months ago

Hello, I would like to try

dancikmad commented 5 months ago

Hi, this has been left for a while together with my other tasks due to being busy with working on some back-end projects.

I should be able to submit a PR this weekend hopefully.

nmatesa commented 5 months ago

I'd be interested in working on this issue for the Codecademy Docs Repository in the 'Learn Git & GitHub' course.

RebeccaCrecelius commented 3 months ago

Hello. CSS is my favorite language of all time! May I please be assigned this issue?

ishg-153 commented 3 months ago

@dancikmad Since there was no response from your end, I am unassigning you.

ishg-153 commented 3 months ago

@RebeccaCrecelius You're assigned!🎉You can look through the Contribution Guide to know more about contributing to Codecademy Docs. Check out the Content Standards and Style Guide, they’ll help you with creating your entry.

I see this is your first time contributing to Codecademy Docs. How did you find out about us?

RebeccaCrecelius commented 3 months ago

@ishg-153 Thank you for assigning me. Do you have a timeframe in which you would like for this to be completed?

I am taking courses at Codecademy. My main focus is the Front-End Engineer Path, but I am also completing the Learn Git & GitHub course.

RebeccaCrecelius commented 3 months ago

I am really confused by this project. Is there anywhere contributors get together to discuss contributions?

ishg-153 commented 3 months ago

Hey @RebeccaCrecelius! What do you need help with?

RebeccaCrecelius commented 2 months ago

@ishg-153 in general, I do not understand. I was looking to contribute with HTML and/ or CSS. However, it seems as though this project is supposed to be written in Markdown. Is that correct?

ishg-153 commented 2 months ago

@RebeccaCrecelius, yes! The term is written in a .md file, but it is about CSS text-decoration property. And you are only expected to add an image of the already existing example in the current entry.

Please let me know if you will be able to work on this issue.

RebeccaCrecelius commented 2 months ago

@ishg-153 Thank you for clarifying. Yes, I would still like to work on the entry. I will look at it again tomorrow and let you know if I have any trouble.

RebeccaCrecelius commented 2 months ago

@ishg-153 I just submitted the updates. I did notice there was some content which seemed a bit confusing. It is regarding the p tag being set to center. I was not sure if that was a typo or if it was something to be updated later, so I did not change it. Looking forward to the review.

ishg-153 commented 2 months ago

Hey @RebeccaCrecelius, thanks for pointing that out. You can go ahead and make a change to that sentence so that it is more related to the example below it. (i.e the text-decoration property and its underline value)

RebeccaCrecelius commented 2 months ago

@ishg-153 Sounds good. I will update it soon.

RebeccaCrecelius commented 2 months ago

@ishg-153 I am not sure if this is because my first commit has yet to be reviewed and merged, but I made the changes to the text. It now matches the example. When running git log, I am showing the commit was successful. However, I am not getting the option to compare an pull. The branch I am working on is currently four commits ahead of the main branch.