Reversed MockObject_Generator condition

Codeception / Stub

Flexible Stub wrapper for PHPUnit's Mock Builder

MIT License

296 stars 17 forks source link

Reversed MockObject_Generator condition #4

Closed Naktibalda closed 6 years ago

Naktibalda commented 6 years ago

This change allows to use Codeception\Stub with my ZF1 projects (Zend_Loader raises fatal error if required file does not exist). Stub::makeEmpty breaks code coverage in Codeception 2.4, so if this patch isn't merged, I won't be able to use Codeception 2.4

Codeception tests with this change passed: https://travis-ci.org/Codeception/Codeception/builds/365542285

Naktibalda commented 6 years ago

I kept this pull request open for 5 weeks, nobody has objected.

dereuromark commented 6 years ago

:-1:

dereuromark commented 6 years ago

!class_exists('PHPUnit\Framework\MockObject\Generator') must be kept as well!

This is not BC otherwise

Naktibalda commented 6 years ago

has it caused any problems to you?