search

Codeception / lib-innerbrowser

InnerBrowser
MIT License
80 stars 20 forks source link

Changes in PR #48 break backward compat? #49

Closed nrocy closed 2 years ago

nrocy commented 2 years ago

PR #48 replaced deprecated calls to parents() with ancestors() but this project package.json seems to allow for symfony/dom-crawler 4.4: ^4.4 | ^5.4 | ^6.0

The ancestors() function wasn't added to dom-crawler until 5.3.0-BETA-1 so this seems to be a backward-compat breaking change.

Happy to help assist fix this as it's breaking our tests, how would you prefer to resolve it?

Thanks!

/cc @TavoNiievez

TavoNiievez commented 2 years ago

@nrocy your report is valid.

we'll probably have to use method_exists() before using ancestors(), otherwise use parents()

TavoNiievez commented 2 years ago

If you have time please make a PR for this and tag me to merge ASAP

nrocy commented 2 years ago

@TavoNiievez thanks for the quick response, will sort :)

simonhammes commented 2 years ago

See https://github.com/Codeception/lib-innerbrowser/pull/41