Codeception / lib-innerbrowser

InnerBrowser
MIT License
80 stars 20 forks source link

Align seeCheckboxIsChecked() and dontSeeCheckboxIsChecked() parameter types #57

Closed ziadoz closed 2 years ago

ziadoz commented 2 years ago

I've noticed an inconsistency whilst trying to upgrade to 5.0.0-RC2.

Both the seeCheckboxIsChecked() and dontSeeCheckboxIsChecked() used to accept an array parameter (e.g. ['css' => '.foobar']), but dontSeeCheckboxIsChecked() no longer does.

I looked and it seems like there's nothing stopping both methods accepting the array formatted parameter, so I've removed the type on dontSeeCheckboxIsChecked() and added some test coverage.

I wasn't sure if lib-web also needed updating, but I can do that if necessary.

Naktibalda commented 2 years ago

Released as 3.1.2