search

Codeception / module-laravel

Modern Laravel module for Codeception
MIT License
5 stars 13 forks source link

Feature: Ability to assert something exists (or not) in cache #3

Open Jamesking56 opened 4 years ago

Jamesking56 commented 4 years ago

Hello,

Would be really useful if there was a way to ensure (or not) that something existed in Laravel's cache.

I want to make sure that certain things are cached correctly when doing functional tests.

Naktibalda commented 4 years ago

It is up to you to figure it out and implement it. This module has no maintainer.

Jamesking56 commented 4 years ago

Oh right I thought this module was maintained

Naktibalda commented 4 years ago

I can merge your pull request and release a new version, but we haven't had a regular Laravel expert for a few years.

Jamesking56 commented 4 years ago

I'm happy to maintain this module if you like, been using Laravel daily since v3

On Thu, 2 Jan 2020, 8:49 pm Gintautas Miselis, notifications@github.com wrote:

I can merge your pull request and release a new version, but we haven't had a regular Laravel expert for a few years.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Codeception/module-laravel5/issues/1?email_source=notifications&email_token=AAB52NJNBBA2UMCI3XYBKPDQ3ZHNFA5CNFSM4KCFCK72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7LYEY#issuecomment-570342419, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB52NL4JSZF2ORIIUZXQDDQ3ZHNFANCNFSM4KCFCK7Q .

TavoNiievez commented 3 years ago

@Jamesking56 are you still interested in submitting a PR for this new feature?

If so, please follow the contribution guide.

As long as you can verify that it works in the test project and you can document the method, I will gladly help you get it merged.

Also note that version 2.0 of this module was released with compatibility for Laravel 6, Laravel 7, and Laravel 8, so you can find new utility in this module.

Cheers!