search

Codeception / module-phalcon4

Phalcon 4 module for Codeception
https://codeception.com/docs/modules/Phalcon4
MIT License
3 stars 8 forks source link

Cookie experation type missmatch. #18

Closed dcolt closed 2 years ago

dcolt commented 2 years ago

Symphonys browser-kit Cookie takes $expires as a string|null Phalcon4s cooke typehint is set as string, but it's actual return is an int. (Tested with Phalcon 4.1.2)

so in src/Codeception/Lib/Connector/Phalcon4.php:L152 needs to be casted to a string (string)$cookie->getExpiration()

Jeckerson commented 2 years ago

@dcolt Hello, could you submit the PR?

dcolt commented 2 years ago

Added: #19