search

Codeception / module-phalcon4

Phalcon 4 module for Codeception
https://codeception.com/docs/modules/Phalcon4
MIT License
3 stars 8 forks source link

Cookie not compatible with symfony/browser-kit #24

Open hinablue opened 2 years ago

hinablue commented 2 years ago

In the old version of symfony/browser-kit, the Cookie's __construct is

public function __construct(string $name, ?string $value, string $expires = null, string $path = null, string $domain = '', bool $secure = false, bool $httponly = true, bool $encodedValue = false, string $samesite = null) { ... }

And in the Phalcon4, using cookie set with expires is only allow integer, so there will be TypeError when running the test.

[TypeError] Argument 3 passed to Symfony\Component\BrowserKit\Cookie::__construct() must be of the type string or null, int given, called in /root/.composer/vendor/codeception/module-phalcon4/src/Codeception/Lib/Connector/Phalcon4.php on line 156

Maybe convert the timestamp to UTC String for old symfony/browser-kit?

hinablue commented 2 years ago

Oops. I saw the master maybe fixed. But v1.0.7 is not.