search

Codeception / module-playwright

Playwright testing module in PHP
MIT License
5 stars 2 forks source link

grabCurrentUrl vs grabFromCurrentUrl #2

Closed eXorus closed 1 month ago

eXorus commented 1 month ago

In WebDriver it's grabFromCurrentUrl In this module it's grabCurrentUrl

Is it expected ?

eXorus commented 1 month ago

same for executeScript vs executeJS

eXorus commented 1 month ago

same for refreshPage vs reloadPage

eXorus commented 1 month ago

same for waitForFunction? vs waitForJS

same for waitForVisible vs waitForElementVisible sale for waitForInvisible vs waitForElementNotVisible

eXorus commented 1 month ago

seeCurrentUrlMatches doesn't exist.

eXorus commented 1 month ago

same for waitForClickable vs waitForElementClickable

and it doesn't exist.

DavertMik commented 1 month ago

Thanks, adding aliases. Somehow this was not in original test suite

DavertMik commented 1 month ago

This one should be fixed by last commit in main branch Maybe tests also needed to be added

DavertMik commented 1 month ago

Fixed and added tests https://github.com/Codeception/module-playwright/actions/runs/10984757588