search

Codeception / module-yii2

Codeception module for Yii2 framework
MIT License
16 stars 36 forks source link

Application class config #48

Closed DBX12 closed 3 years ago

DBX12 commented 3 years ago

As I was testing an application, I realized that it is impossible to change the application class without creating extra config files. By checking the code, I saw that it should be possible to determine the application class by setting a root level class key in the application config file (e.g. common/config/test.php). The issue with that is yii_test is loading this config file as well and get a yii\base\UnknownPropertyException with the message 'Setting unknown property: yii\console\Application::class'. So either you modify yii_test to unset the class key before creating the console application or create another config file just for codeception and define the class there. Thus I felt, it would be more sensible to have this configuration value in the codeception module itself.

SamMousa commented 3 years ago

@samdark could you confirm that the reasoning makes sense? I'm not familiar with the yii app templates or yii_test.

The code itself here LGTM

samdark commented 3 years ago

Thanks.