search

Codeception / module-yii2

Codeception module for Yii2 framework
MIT License
16 stars 36 forks source link

Annotate throws with FQN #54

Closed DBX12 closed 2 years ago

DBX12 commented 2 years ago

The pull request as discussed on #42

Also I fixed one documentation issue, my IDE highlighted several more but for that one I was certain that it would not have any side effects.

And again, I would highly appreciate getting the hacktoberfest-accepted label :)

SamMousa commented 2 years ago

Can we not tackle the real issue? To me the issue is not docblock but bad code generation?

DBX12 commented 2 years ago

I think that would be something which should happen in codeception itself and not in a module, right? I've skimmed the open issues on codeception/codeception quickly and did not find anything regarding this issue. However, after checking the code, it seems like the docblock is just copy-pasted from the module. I looked at two other modules (doctrine2 and redis) and have seen that those also don't use FQNs for their @throws annotations. So fixing it in codeception might be truly the best option. I'll open an issue in the main repo and see what happens.

SamMousa commented 2 years ago

Feel free to right a PR for that!

samdark commented 2 years ago

This one is right to be merged anyway. @DBX12 would you please link to the issue you've created?

DBX12 commented 2 years ago

You mean the issue at codeception/codeception? The issue is here and a PR attempting to fix it is here but I'm currently stuck with a conflict in the dependencies and was requesting input from the Maintainers / other contributors as it would need a bigger change.