search

Codeception / module-yii2

Codeception module for Yii2 framework
MIT License
16 stars 36 forks source link

Merge tests repo #56

Closed DBX12 closed 2 years ago

DBX12 commented 2 years ago

I moved the tests from the separate directory to this repository so they can be cloned altogether as discussed here. (Ok, discussion is a strong word, it was talked about in two comments :D )

I can squash the commits if you want (or you do a squash merge), I kept all of them to make retracing my steps easier.

I hope I got the github workflow right, that was my first time working with them. And as always, I would greatly appreciate the hacktoberfest-accepted label on the PR :)

DBX12 commented 2 years ago

As written above, I'm not "fluent" in github workflows. As far as I can judge this is because fxp/composer-asset-plugin is missing, would adding composer global require "fxp/composer-asset-plugin:~1.3" in the Install dependencies step fix the issue?

samdark commented 2 years ago

fxp/composer-asset-plugin should not be required for current Yii 2 apps.

samdark commented 2 years ago

https://github.com/yiisoft/yii2-app-advanced/blob/master/composer.json#L39 - this should help.

DBX12 commented 2 years ago

Copying the .gitignore contents first and thinking about it second was not the smartest move :sweat_smile:

samdark commented 2 years ago

👍