search

Codeception / module-yii2

Codeception module for Yii2 framework
MIT License
16 stars 36 forks source link

Preperation for Codeception v5.0 #61

Closed developedsoftware closed 2 years ago

developedsoftware commented 2 years ago

Now that yii2 supports PHP 8.1 - I was wondering how compatible this module will be with Codeception v.5 which also requires 8.1

Naktibalda commented 2 years ago

Some work will be necessary, most likely due to signature change in Web interface.

developedsoftware commented 2 years ago

Happy to help contribute

Naktibalda commented 2 years ago

@TavoNiievez skipped this module, probably because it had more maintainers then all other modules put together :)

You have to update composer.json and change minimum-stability to dev,

"codeception/codeception": "^5.0.0-alpha2",
"codeception/lib-innerbrowser": "^3.0",

and then fix all type issues.

Naktibalda commented 2 years ago

Example: https://github.com/Codeception/module-laminas/pull/22/files

TavoNiievez commented 2 years ago

Just for the record, I did start working on this a few months ago:

https://github.com/Codeception/module-yii2/compare/master...TavoNiievez:master

, but to fix the tests I also had to adapt the test project https://github.com/Codeception/yii2-tests , the code of the tests, however, are in this repository (https://github.com/Codeception/module-yii2/pull/56) and not there so it would have taken me more time than expected since I'm not a yii expert.

developedsoftware commented 2 years ago

Just to throw an option out there - if you have already started updating this repo - perhaps we could revisit?

I could do the yii2 coding? And together we should be able to get this pushed through?

TavoNiievez commented 2 years ago

What I did was create a 2.0 branch and integrate my changes in it, at the moment I don't have much time to code myself, but I'll be very attentive to review PR's directed to that branch.

Naktibalda commented 2 years ago

If the purpose of 2.0 branch is preparation for Codeception 5, I would like to point out that I released 3.0.0 versions of module-asserts and module-filesystem, because some modules had 2.x versions clearly meant for Codeception 4.x

It would be good to release new versions of all modules as 3.0.0 for consistency (except modules that have existing 3.x versions compatible with Codeception 4).

developedsoftware commented 2 years ago

If the purpose of 2.0 branch is preparation for Codeception 5, I would like to point out that I released 3.0.0 versions of module-asserts and module-filesystem, because some modules had 2.x versions clearly meant for Codeception 4.x

It would be good to release new versions of all modules as 3.0.0 for consistency (except modules that have existing 3.x versions compatible with Codeception 4).

I agree !

TavoNiievez commented 2 years ago

In the case of module-yii, a 2.x version compatible with the 2.x versions of the other modules was not even released. I'm not sure if you guys are going to directly release a 3.x version skipping the 2.x, for now i renamed the branch to codecept5 since I'm probably not the one to tag this.

Patrick-Remy commented 2 years ago

In the case of module-yii, a 2.x version compatible with the 2.x versions of the other modules was not even released.

I'd love if there was any release targeting codeception 4.x and php 7.4 + 8.0 support, as a mid-step release, as all other codeception modules used in my Yii project also have this, but due to #58 I can't update to those. And as not the full codebase of a large project is compatible to 8.0, I couldn't use a v3 version which would require php 8.

developedsoftware commented 2 years ago

Hopefully fixed in #63

developedsoftware commented 2 years ago

Do you have plans to merge the codecept branch into master?