search

Codeception / module-yii2

Codeception module for Yii2 framework
MIT License
16 stars 36 forks source link

Compatibility with Codeception 5 and PHP 8.1 #63

Closed developedsoftware closed 2 years ago

developedsoftware commented 2 years ago

All tests pass.

Changes to yii2-advanced-template are required and are not breaking changes. So I will submit a PR to that repo shortly - this PR is here https://github.com/yiisoft/yii2-app-advanced/pull/518

Once this and the above pull requests are accepted this module is good to go with Codecept V5 and PHP 8.1

Screenshot 2022-02-23 at 16 59 59
developedsoftware commented 2 years ago

Ok no problem. I will action all the above points shortly.

developedsoftware commented 2 years ago

Changes made but blocked by other dependencies.

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires codeception/module-filesystem ^3.0 -> satisfiable by codeception/module-filesystem[3.0.x-dev].
    - codeception/module-filesystem 3.0.x-dev requires codeception/codeception dev-5.0-interfaces as 5.0.0 -> found codeception/codeception[dev-5.0-interfaces] but it conflicts with your root composer.json require (^5.0.0-alpha2).
  Problem 2
    - Root composer.json requires codeception/codeception ^5.0.0-alpha2 -> satisfiable by codeception/codeception[5.0.0-alpha2, 5.0.x-dev].
    - codeception/verify dev-master requires phpunit/phpunit ^9.3 -> satisfiable by phpunit/phpunit[9.3.0, ..., 9.5.x-dev].
    - You can only install one version of a package, so only one of these can be installed: phpunit/phpunit[dev-master, 7.5.0, ..., 7.5.20, 8.0.0, ..., 8.5.x-dev, 9.0.0, ..., 9.5.x-dev].
    - codeception/codeception[5.0.0-alpha2, ..., 5.0.x-dev] require phpunit/phpunit dev-master as 9.5.99 -> satisfiable by phpunit/phpunit[dev-master].
    - Root composer.json requires codeception/verify dev-master -> satisfiable by codeception/verify[dev-master].

Will keep this open until the above can be satisfied. Cheers!

developedsoftware commented 2 years ago

I will fix remaining tests now I can get composer running on my local machine.

developedsoftware commented 2 years ago

With codeception/verify dropped back down to the original version, all tests now pass...

Naktibalda commented 2 years ago

I was confident that I released codeception/module-filesystem 3.0.0, but apparently I didn't.

master branch was codeception 5 ready, we have to decide if we keep master branch or 3.0 branch.

developedsoftware commented 2 years ago

I think a v3.0 branch would be good to keep it consistent with the other repos. But ultimately it doesn’t matter right ?

Naktibalda commented 2 years ago

Master branch is more consistent.

Most modules have master branch only, in some modules 1.x or 1.0 braches were created for applying patches to older versions.

Getting rid of master branch would be a new thing.

developedsoftware commented 2 years ago

Maybe keep it in master branch and just tag the relevant release if it has breaking changes ?

developedsoftware commented 2 years ago

Codecept/verify 2.2 working and all tests pass. Hoping this can now be merged in once approved by everyone?

samdark commented 2 years ago

👍