Adding log from Yii to artifacts when test fails

Codeception / module-yii2

Codeception module for Yii2 framework

MIT License

16 stars 36 forks source link

Adding log from Yii to artifacts when test fails #8

Closed aywan closed 2 years ago

SamMousa commented 4 years ago

I'm going to close & reopen this. Hopefully it will then allow the new CI to run properly!

aywan commented 4 years ago

I will try to fix tests soon

samdark commented 3 years ago

@aywan would you please merge master into the PR branch. Tests are now in order with GitHub actions in place.

SamMousa commented 3 years ago

This breaks BC, since the nullable argument is not optional. Other than that I like the idea

aywan commented 3 years ago

Why tests are in external repo?

SamMousa commented 3 years ago

Because the module wasn't, originally.. Since codeception modules have been split to separate repos, we could merge the tests back into this one.

DBX12 commented 2 years ago

Off-topic for this pull request: I would really like to see the tests in the module repo as well. It was confusing to clone the repo and see no tests folder the first time :D

SamMousa commented 2 years ago

A PR moving them would be greatly appreciated!

samdark commented 2 years ago

So now tests are moved.

developedsoftware commented 2 years ago

Can this be merged?

samdark commented 2 years ago

Thanks!