Fix HTML report merging for multiple suites

reinholdfuereder commented 2 years ago

Fixes https://github.com/Codeception/robo-paracept/issues/69

So far only the suites of the first HTML report were in the final merged HTML report. And when the first HTML report (luckily) already contained all suites, then all tests from the other HTML reports were always merged into the first suite (instead of the same non-first one).

ccsuperstar commented 2 years ago

Thanks a lot, I still have a problem, with duplicate suite

And in a parallel run context, each run has an execution time The final merge of the reports aggregates each of the reports However, in my opinion, the execution time of the final merge should be the execution time of the longest run and not the sum of the execution times of each run

Would it be possible to do it in this PR, or am I opening a new issue?

reinholdfuereder commented 2 years ago

Thanks a lot, I still have a problem, with duplicate suite ...

And in a parallel run context, each run has an execution time The final merge of the reports aggregates each of the reports However, in my opinion, the execution time of the final merge should be the execution time of the longest run and not the sum of the execution times of each run

Would it be possible to do it in this PR, or am I opening a new issue?

Hm, I (as a complete newbie to this project) would say please open a new issue for that, because:

this (summing up of execution times) seems to be implemented on purpose like that (even the method comments claim that) and is not just a bug,
and I am also not really sure what users would expect: I think in fact both execution times (sum and maximum) may make sense or may be of interest?

vansari commented 2 years ago

@reinholdfuereder Thank you for your contribution. Is it possible that you write a Unit Test which covers this new changes? Thanks a lot.

Codeception / robo-paracept

Fix HTML report merging for multiple suites #105