search

Codeception / robo-paracept

Robo tasks for Codeception tests parallel execution
MIT License
57 stars 59 forks source link

Remove TaskIO trait from merge reports, as BaseTask already uses it. #17

Closed pingers closed 7 years ago

pingers commented 7 years ago

I don't really know much about this project, but @Dorkstars mentioned in gitter.im that this was causing a problem, so here's what I think the fix is :smile:

From gitter.im:

@Dorkstars Hello, how can i fix error: ERROR: Robo\Task\BaseTask and Robo\Common\TaskIO define the same property ($config) in the composition of Codeception\Task\MergeHTMLReportsTask. This might be incompatible, to improve maintainability consider using accessor methods in traits instead. Class was composed

Looks like BaseTask already uses the TaskIO trait, so no need for the reports to also use that trait - it's inherited from BaseTask now.

dzoeteman commented 7 years ago

@pingers SplitTests task also has this issue.

dzoeteman commented 7 years ago

@DavertMik any update on this PR?

pingers commented 7 years ago

I can add the SplitTests task issue to this PR too in a couple hours.

Revisor commented 7 years ago

@DavertMik Can this be merged and released, please?

DavertMik commented 7 years ago

Ok, ok, guys. Here I am, doing that right now ) :+1:

Revisor commented 7 years ago

Thank you :)